fix(sdk): initialize sandbox annotations#2296
Merged
Merged
Conversation
The SDK merged after CreateSandboxRequest and ObjectMeta gained annotations on main, leaving stale struct initializers that prevented the crate and its tests from compiling. Initialize the curated request and mock metadata with empty annotation maps. Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 15, 2026 14:59
drew
enabled auto-merge (squash)
July 15, 2026 15:07
pimlock
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the SDK test failures introduced when #1862 merged after the sandbox annotations protobuf changes. The SDK and its mock gateway now initialize the new annotation maps, restoring compilation on main.
Related Issue
Follow-up to #1862 and commit e6f319c.
Changes
CreateSandboxRequest.annotationsin the curated SDK clientObjectMeta.annotationsin the mock gateway fixtureTesting
mise run pre-commitpassesAdditional verification:
cargo test -p openshell-sdkmise run testChecklist